Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Nov 7 12:41:16 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11504 )

Change subject: gsm0808: add BSSMAP Cell Identifier matching API
......................................................................


Patch Set 4:

(1 comment)

> (1 comment)
 > 
 > I think you should also update TODO-RELEASE file as well. Provided
 > it's still used during the release preparation. Pau?

Not really mandatory, I end up looking at git log anyway, since people usually forget to add stuff there (or they dn't realize that they are changing API/ABI at all).

https://gerrit.osmocom.org/#/c/11504/4/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:

https://gerrit.osmocom.org/#/c/11504/4/src/gsm/gsm0808_utils.c@1401
PS4, Line 1401: 				match_nr --;
> That looks odd - why space before decrement?
Agree



-- 
To view, visit https://gerrit.osmocom.org/11504
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5535f0d149c2173294538df75764dd181b023312
Gerrit-Change-Number: 11504
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Nov 2018 12:41:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181107/81ca7c73/attachment.html>


More information about the gerrit-log mailing list