Change in osmo-gsm-tester[master]: ms_driver: use the util.Dir and create one dir per instance

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Nov 7 10:41:45 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11598 )

Change subject: ms_driver: use the util.Dir and create one dir per instance
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/11598/2/src/osmo_gsm_tester/ms_driver.py
File src/osmo_gsm_tester/ms_driver.py:

https://gerrit.osmocom.org/#/c/11598/2/src/osmo_gsm_tester/ms_driver.py@74
PS2, Line 74:             self.event_server_sk_tmp_dir = tempfile.mkdtemp('', 'ogteventserversk')
if suite_run != None, you should use it to create the tmp dir inside the run dir, like we do with all other resources/objects. This way everything ends up per-test in a dir tree which can be archived by jenkins.
You can do that on a followup patch.



-- 
To view, visit https://gerrit.osmocom.org/11598
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0f2fe99f6a6640606eb4e69fb1a2d22eae9b2c8
Gerrit-Change-Number: 11598
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:41:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181107/7063d720/attachment.htm>


More information about the gerrit-log mailing list