Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Nov 7 10:20:42 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11504 )

Change subject: gsm0808: add BSSMAP Cell Identifier matching API
......................................................................


Patch Set 4:

> jenkins tests with gcc 6.3.0-18+deb9u1, my gcc is gcc (Debian
 > 8.2.0-9) 8.2.0.
 > 
 > So a) this code will work as soon as we upgrade gcc.
 > But b) do we really want to depend on newer gcc :/
 > 
 > Appears I need to think of some cumbersome magic to initialize the
 > structs.

afaiu, moving them inside a function (main()?) may be enough, since then they are not static (of course removing the static keyword).


-- 
To view, visit https://gerrit.osmocom.org/11504
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5535f0d149c2173294538df75764dd181b023312
Gerrit-Change-Number: 11504
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Nov 2018 10:20:42 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181107/8ab8864d/attachment.htm>


More information about the gerrit-log mailing list