Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Nov 6 20:11:52 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11504 )

Change subject: gsm0808: add BSSMAP Cell Identifier matching API
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11504/2/tests/gsm0808/gsm0808_test.c
File tests/gsm0808/gsm0808_test.c:

https://gerrit.osmocom.org/#/c/11504/2/tests/gsm0808/gsm0808_test.c@1721
PS2, Line 1721: struct test_cell_id_matching_data {
> Shouldn't all these structs be static? Maybe that helps with compiler error.
yep, should be static, regardless; thanks for catching. Since I can't reproduce the compiler error, let's see what jenkins says this time round.



-- 
To view, visit https://gerrit.osmocom.org/11504
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5535f0d149c2173294538df75764dd181b023312
Gerrit-Change-Number: 11504
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Nov 2018 20:11:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181106/04768995/attachment.html>


More information about the gerrit-log mailing list