Change in libosmocore[master]: socket.c: fix IP and port buffer sizes

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Nov 6 19:22:22 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11520 )

Change subject: socket.c: fix IP and port buffer sizes
......................................................................


Patch Set 1: Code-Review+1

in both cases this reduces the buffer size, resp. from 16 to 6 and from 64 to 46. It's probably correct and not harmful, but I ask myself, why bother?


-- 
To view, visit https://gerrit.osmocom.org/11520
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia25e2f3277ad2f60df31c08d12f42c1e6d2a14a6
Gerrit-Change-Number: 11520
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Nov 2018 19:22:22 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181106/adcf3725/attachment.html>


More information about the gerrit-log mailing list