Change in libosmocore[master]: Fix deprecation warning in gsm0808_test

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Tue Nov 6 17:25:57 UTC 2018


Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11602 )

Change subject: Fix deprecation warning in gsm0808_test
......................................................................

Fix deprecation warning in gsm0808_test

Use gsm0808_create_layer3_2() directly instead of deprecated wrapper.

Change-Id: I44772666c929dfd94d25953379cf51b371ce202c
---
M tests/gsm0808/gsm0808_test.c
1 file changed, 12 insertions(+), 4 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c
index 7111db9..671b839 100644
--- a/tests/gsm0808/gsm0808_test.c
+++ b/tests/gsm0808/gsm0808_test.c
@@ -102,7 +102,16 @@
 		0xef, 0xcd, GSM0808_SCT_FR2 | 0xa0, 0x9f,
 		GSM0808_SCT_CSD | 0x90, 0xc0
 	};
-
+	struct osmo_cell_global_id cgi = {
+		.lai = {
+			.plmn = {
+				.mcc = 0x2244,
+				.mnc = 0x1122,
+			},
+			.lac = 0x3366,
+		},
+		.cell_identity = 0x4488,
+	};
 	struct msgb *msg, *in_msg;
 	struct gsm0808_speech_codec_list sc_list;
 	printf("Testing creating Layer3 (AoIP)\n");
@@ -113,9 +122,8 @@
 	in_msg->l3h = in_msg->data;
 	msgb_v_put(in_msg, 0x23);
 
-	msg =
-	    gsm0808_create_layer3_aoip(in_msg, 0x1122, 0x2244, 0x3366, 0x4488,
-				       &sc_list);
+	msg = gsm0808_create_layer3_2(in_msg, &cgi, &sc_list);
+
 	VERIFY(msg, res, ARRAY_SIZE(res));
 
 	msgb_free(msg);

-- 
To view, visit https://gerrit.osmocom.org/11602
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I44772666c929dfd94d25953379cf51b371ce202c
Gerrit-Change-Number: 11602
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181106/aee52d87/attachment.htm>


More information about the gerrit-log mailing list