Change in osmo-bts[master]: LC15: Fix missing fill frame and GSM 05.08 mandatory frame

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Nov 6 12:21:31 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/5753 )

Change subject: LC15: Fix missing fill frame and GSM 05.08 mandatory frame
......................................................................


Patch Set 9: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/5753/9/src/osmo-bts-litecell15/l1_if.c
File src/osmo-bts-litecell15/l1_if.c:

https://gerrit.osmocom.org/#/c/5753/9/src/osmo-bts-litecell15/l1_if.c@365
PS9, Line 365: 	LOGP(DL1C, LOGL_DEBUG, "%s tn=%u: Sending fill frame on in none DTX mode "
This text keeps being really confusing and needs fixing.

First, we don't send any fill frame here, we only create and fill the message.
Second: "on in none DTX mode" makes no sense to me.



-- 
To view, visit https://gerrit.osmocom.org/5753
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40e9bf9438c0b400e4d29eb39ffae37207e34db6
Gerrit-Change-Number: 5753
Gerrit-PatchSet: 9
Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 06 Nov 2018 12:21:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181106/01c3d791/attachment.htm>


More information about the gerrit-log mailing list