Change in osmo-mgw[master]: add DLCX command statistics to osmo-mgw

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Tue Nov 6 11:00:39 UTC 2018


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11521 )

Change subject: add DLCX command statistics to osmo-mgw
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11521/1/src/libosmo-mgcp/mgcp_protocol.c
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/#/c/11521/1/src/libosmo-mgcp/mgcp_protocol.c@1573
PS1, Line 1573:  *  (called once at startup by main function) */
> That's first notice I get regarding we use OSMO_ASSERT during allocations, I would say we usually do […]
Can you please be more specific? How strongly do you care about the OSMO_ASSERT?
I am getting different opinions from you and Harald. I have already indicated that I will do whatever both of you want, but you must make non-contradictory suggestions.



-- 
To view, visit https://gerrit.osmocom.org/11521
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0dde2faf02fd68a69f986973d39b1bea367039b
Gerrit-Change-Number: 11521
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Nov 2018 11:00:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181106/04f9ea26/attachment.html>


More information about the gerrit-log mailing list