Change in osmo-bsc[master]: bsc: gsm0808: Fix return code in bsc_compl_l3

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Mon Nov 5 23:58:50 UTC 2018


Max has posted comments on this change. ( https://gerrit.osmocom.org/11605 )

Change subject: bsc: gsm0808: Fix return code in bsc_compl_l3
......................................................................


Patch Set 1:

(1 comment)

Or, even better, use errno constants.

https://gerrit.osmocom.org/#/c/11605/1/src/osmo-bsc/gsm_08_08.c
File src/osmo-bsc/gsm_08_08.c:

https://gerrit.osmocom.org/#/c/11605/1/src/osmo-bsc/gsm_08_08.c@385
PS1, Line 385: 	return complete_layer3(conn, msg, msc) ? 0 : -1;
I think it's better to use another number to distinguish between different error paths.



-- 
To view, visit https://gerrit.osmocom.org/11605
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I722696c3f6402288b51d6fcf51f478b3b0c9f0f0
Gerrit-Change-Number: 11605
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Nov 2018 23:58:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181105/e4bc43c7/attachment.htm>


More information about the gerrit-log mailing list