This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11580 ) Change subject: misc: Use RPATH to avoid having tests to set LD_LIBRARY_PATH ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/11580/2/contrib/jenkins-build-common.sh File contrib/jenkins-build-common.sh: https://gerrit.osmocom.org/#/c/11580/2/contrib/jenkins-build-common.sh@180 PS2, Line 180: # (Osmocom) libraries in `basepath /proc/self/exe`/../lib/. Adds an Shouldn't this be dirname instead of basepath? It's quoted as a subshell but at least my shell doesn't have basepath cmd. https://gerrit.osmocom.org/#/c/11580/2/contrib/jenkins-build-common.sh@189 PS2, Line 189: find bin -depth -type f -exec patchelf --set-rpath '$ORIGIN/../lib/' {} \; Please document in the comments above that this $ORIGIN variable is actually not a shell variable, but one replaced by the linker to be the dirname from where the process is run. I was first really confused about this until I looked it up on the search engine. -- To view, visit https://gerrit.osmocom.org/11580 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If771767dd82662e13b6b10ee7a8b8d0c84dcbdb1 Gerrit-Change-Number: 11580 Gerrit-PatchSet: 2 Gerrit-Owner: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 05 Nov 2018 10:23:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181105/ed102c4b/attachment.htm>