Change in libosmocore[master]: Update 3GPP TS 08.08 Cause handling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Nov 5 03:34:53 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11577 )

Change subject: Update 3GPP TS 08.08 Cause handling
......................................................................


Patch Set 2: Code-Review-1

(7 comments)

https://gerrit.osmocom.org/#/c/11577/2/include/osmocom/gsm/gsm0808.h
File include/osmocom/gsm/gsm0808.h:

https://gerrit.osmocom.org/#/c/11577/2/include/osmocom/gsm/gsm0808.h@178
PS2, Line 178: const char *gsm0808_cause_name(enum gsm0808_cause cause);
(nice! the lack of enum use has caused me a lot of head scratching when trying to figure out *which* cause a context is talking about. I wish we would replace all these uint8_t args with their proper enums.)


https://gerrit.osmocom.org/#/c/11577/2/include/osmocom/gsm/gsm0808_utils.h
File include/osmocom/gsm/gsm0808_utils.h:

https://gerrit.osmocom.org/#/c/11577/2/include/osmocom/gsm/gsm0808_utils.h@110
PS2, Line 110: /*! Return 3GPP TS 08.08 §3.2.2.5 Class of a given Cause */
maybe rather name the newer version -- that would be 48.008, right? -- only problem is consistency with the rest of the file? But no-one should read the outdated specs anymore...


https://gerrit.osmocom.org/#/c/11577/2/include/osmocom/gsm/gsm0808_utils.h@116
PS2, Line 116: /*! Check whether 3GPP TS 08.08 §3.2.2.5 Class has extended bit set */
strictly speaking, these comments should have a doxygen \returns clause ... but whatever


https://gerrit.osmocom.org/#/c/11577/2/include/osmocom/gsm/gsm0808_utils.h@118
PS2, Line 118: { /* check that cause looks like 1XXX0000 where XXX represent class */
(weird formatting, comment in { line)


https://gerrit.osmocom.org/#/c/11577/2/src/gsm/gsm0808.c
File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/#/c/11577/2/src/gsm/gsm0808.c@1274
PS2, Line 1274: static const struct value_string gsm0808_cause_class_names[] = {
(I would be fine with this, but a while back the decision was that the value string arrays should be accessible as public API -- @laforge, I think that was your opinion, fine to leave this hidden in static .c context?)


https://gerrit.osmocom.org/#/c/11577/2/src/gsm/gsm0808.c@1276
PS2, Line 1276: 	{ GSM0808_CAUSE_CLASS_NORM1,		"Normal event" },
shouldn't the name distinguish between 0 and 1?


https://gerrit.osmocom.org/#/c/11577/2/src/gsm/gsm0808.c@1282
PS2, Line 1282: 	{ GSM0808_CAUSE_CLASS_INETW,		"Internetworking" },
I think this should be "Interworking" -- whatever that means :)



-- 
To view, visit https://gerrit.osmocom.org/11577
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31b31dfc22eb4b6b07089e1255246ac458125340
Gerrit-Change-Number: 11577
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Nov 2018 03:34:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181105/f14bb1b5/attachment.htm>


More information about the gerrit-log mailing list