Change in osmo-bsc[master]: LCLS: explicitly check for mode before closing the loop

Neels Hofmeyr gerrit-no-reply at
Mon Nov 5 03:02:37 UTC 2018

Neels Hofmeyr has posted comments on this change. ( )

Change subject: LCLS: explicitly check for mode before closing the loop

Patch Set 1: Code-Review-1

Commit Message:
PS1, Line 10: * explicitly check for MGW mode before closing the loop via MGCP MDCX
I don't see how these two changes end up in the same patch. Please separate orthogonal changes, especially when it's logging tweaks vs. functional changes
File include/osmocom/bsc/bsc_msc_data.h:
PS1, Line 62: extern const struct value_string bsc_lcls_mode_names[];
at some point we agreed to always add something like this:

  static inline const char *bsc_lcls_mode_name(enum bsc_lcls_mode val)
  { return get_value_string(...); }
File src/osmo-bsc/gsm_data.c:
PS1, Line 53: 	{ 0, NULL }
(possible to just write '{}' in the last line)
File src/osmo-bsc/osmo_bsc_lcls.c:
PS1, Line 243: 		get_value_string(bsc_lcls_mode_names, conn->sccp.msc->lcls_mode));
this and the others below get shorter with bsc_lcls_mode_name().
PS1, Line 252: 		struct mgcp_conn_peer mdcx_info = (struct mgcp_conn_peer){
> whitespace missing before {
This is a struct initializer, so I'd favor Max's formatting choice: not place a space. Compare:

  990:		*dst = (struct gsm0808_cell_id_list2){
  996:	*dst = (struct gsm0808_cell_id_list2){

and various others

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie91cc70de20ade2bfa3a1a108c731341f5e739bb
Gerrit-Change-Number: 11565
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at>
Gerrit-CC: Pau Espin Pedrol <pespin at>
Gerrit-Comment-Date: Mon, 05 Nov 2018 03:02:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list