Change in libosmocore[master]: Update cipher reject function

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Nov 2 22:04:02 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11576 )

Change subject: Update cipher reject function
......................................................................

Update cipher reject function

* add note about (yet) unsupported standard feature
* use enum constant instead of hex value

Change-Id: I5cc5fc1ae8d5474dbc8d3385a493adf6420a3c98
Related: OS#3187
---
M src/gsm/gsm0808.c
M tests/gsm0808/gsm0808_test.c
2 files changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index 9ccca4d..e5c3e30 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -275,6 +275,7 @@
 		return NULL;
 
 	msgb_v_put(msg, BSS_MAP_MSG_CIPHER_MODE_REJECT);
+	/* FIXME: support 2-byte cause value as per 3GPP TS 08.08 §3.2.2.5 */
 	msgb_tlv_put(msg, GSM0808_IE_CAUSE, 1, &cause);
 
 	msg->l3h = msgb_tv_push(msg, BSSAP_MSG_BSS_MANAGEMENT, msgb_length(msg));
diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c
index 0b2794f..7111db9 100644
--- a/tests/gsm0808/gsm0808_test.c
+++ b/tests/gsm0808/gsm0808_test.c
@@ -248,7 +248,7 @@
 	struct msgb *msg;
 
 	printf("Testing creating Cipher Reject\n");
-	msg = gsm0808_create_cipher_reject(0x23);
+	msg = gsm0808_create_cipher_reject(GSM0808_CAUSE_CCCH_OVERLOAD);
 	VERIFY(msg, res, ARRAY_SIZE(res));
 	msgb_free(msg);
 }

-- 
To view, visit https://gerrit.osmocom.org/11576
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5cc5fc1ae8d5474dbc8d3385a493adf6420a3c98
Gerrit-Change-Number: 11576
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181102/be2683fa/attachment.html>


More information about the gerrit-log mailing list