Change in osmo-bsc[master]: RSL: restructure MDCX functions

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Nov 2 09:35:55 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11550 )

Change subject: RSL: restructure MDCX functions
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/11550/3/src/osmo-bsc/abis_rsl.c
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/#/c/11550/3/src/osmo-bsc/abis_rsl.c@1860
PS3, Line 1860: struct msgb *rsl_make_ipacc_mdcx(const struct gsm_lchan *lchan, uint32_t dest_ip, uint16_t dest_port)
why do you keep dest_ip and dest_port as params despite they come from lchan? Because in later patches you require to pass  ones not coming from lchan? or for no reason?



-- 
To view, visit https://gerrit.osmocom.org/11550
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffe2f4f10e841fc36965cce02b4e5f017a5ae6c8
Gerrit-Change-Number: 11550
Gerrit-PatchSet: 3
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Nov 2018 09:35:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181102/740b3d17/attachment.html>


More information about the gerrit-log mailing list