Change in osmo-msc[master]: lu_fsm: result cb: use proper cause type (warning/coverity)

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Nov 1 17:10:11 UTC 2018


Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11531 )

Change subject: lu_fsm: result cb: use proper cause type (warning/coverity)
......................................................................

lu_fsm: result cb: use proper cause type (warning/coverity)

enum gsm48_gmm_cause is the wrong enum to pass to lu_fsm_failure(). Use enum
gsm48_reject_value instead.

Change-Id: If661f72056decb28c0ee82ad2449630a24d4f31c
---
M src/libvlr/vlr_lu_fsm.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c
index bf23551..717db42 100644
--- a/src/libvlr/vlr_lu_fsm.c
+++ b/src/libvlr/vlr_lu_fsm.c
@@ -1188,8 +1188,8 @@
 			/* continue in MSC ?!? */
 		} else {
 			/* unsuccessful case */
-			enum gsm48_gmm_cause cause =
-				*(enum gsm48_gmm_cause *)data;
+			enum gsm48_reject_value cause =
+				*(enum gsm48_reject_value *)data;
 			/* Ignoring standalone mode for now. */
 			if (0 /* procedure_error && vlr->cfg.standalone_mode */) {
 				osmo_fsm_inst_state_chg(fi,

-- 
To view, visit https://gerrit.osmocom.org/11531
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If661f72056decb28c0ee82ad2449630a24d4f31c
Gerrit-Change-Number: 11531
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181101/5b816e60/attachment.html>


More information about the gerrit-log mailing list