Change in osmo-pcu[master]: Move EGPRS WS computation to C code

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Nov 1 16:11:16 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/6241 )

Change subject: Move EGPRS WS computation to C code
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/6241/4/src/mslot_class.c
File src/mslot_class.c:

https://gerrit.osmocom.org/#/c/6241/4/src/mslot_class.c@301
PS4, Line 301: 	return OSMO_MIN((num_pdch != 1) ? (128 * num_pdch) : 192, OSMO_MAX(64,
This code looks unreadable...



-- 
To view, visit https://gerrit.osmocom.org/6241
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie411ea2bbfca442b33405584f15687a7ffcbb53c
Gerrit-Change-Number: 6241
Gerrit-PatchSet: 4
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 01 Nov 2018 16:11:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181101/296e3c5a/attachment.html>


More information about the gerrit-log mailing list