Change in osmo-pcu[master]: Move EGPRS WS computation to C code

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Nov 1 15:19:07 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/6241 )

Change subject: Move EGPRS WS computation to C code
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/6241/2/src/tbf_dl.cpp
File src/tbf_dl.cpp:

https://gerrit.osmocom.org/#/c/6241/2/src/tbf_dl.cpp@1351
PS2, Line 1351: 	uint16_t ws = egprs_window_size(bts->bts_data()->ws_base, bts->bts_data()->ws_pdch, pcu_bitcount(dl_slots()));
Maybe move bts_data() to a local variable since you use it twice, and then simplify this line.


https://gerrit.osmocom.org/#/c/6241/2/src/tbf_ul.cpp
File src/tbf_ul.cpp:

https://gerrit.osmocom.org/#/c/6241/2/src/tbf_ul.cpp@588
PS2, Line 588: 	uint16_t ws = egprs_window_size(bts->bts_data()->ws_base, bts->bts_data()->ws_pdch, pcu_bitcount(ul_slots()));
Same here.



-- 
To view, visit https://gerrit.osmocom.org/6241
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie411ea2bbfca442b33405584f15687a7ffcbb53c
Gerrit-Change-Number: 6241
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Nov 2018 15:19:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181101/30b06222/attachment.html>


More information about the gerrit-log mailing list