Change in osmo-ttcn3-hacks[master]: library: introduce Facility IE templates for USSD

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue May 29 19:40:08 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9368 )

Change subject: library: introduce Facility IE templates for USSD
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/#/c/9368/1/library/USSD_Templates.ttcn
File library/USSD_Templates.ttcn:

https://gerrit.osmocom.org/#/c/9368/1/library/USSD_Templates.ttcn@41
PS1, Line 41: 	octetstring ussd_dcs := '0F'O, // GSM 7-bit default alphabet
I recommend adding either "const" definitions for this, or add an enumerated and then use enum2int() here.  Same for op_code as well as for ussd_dcs.


https://gerrit.osmocom.org/#/c/9368/1/library/USSD_Templates.ttcn@60
PS1, Line 60: template SS_FacilityInformation ts_ML3_FACILITY_USSD_RETURN_ERROR(
is this a general FACILITY_RETURN_ERORR template that can also be used for structured SS?  Then the naming might be different.


https://gerrit.osmocom.org/#/c/9368/1/library/USSD_Templates.ttcn@62
PS1, Line 62: 	integer errcode := 71 // Unknown alphabet
same here for the error code.  It's sad that the ASN1 compiler apparently doesn't generate enums for that, so you have to repeat those :/


https://gerrit.osmocom.org/#/c/9368/1/library/USSD_Templates.ttcn@67
PS1, Line 67: 			errcode := { local := 71 },
i think you want "local := errcode" here?



-- 
To view, visit https://gerrit.osmocom.org/9368
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc3e8f70230d656b2f0994ea0c63e6554b6165de
Gerrit-Change-Number: 9368
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 29 May 2018 19:40:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180529/e12ffca2/attachment.htm>


More information about the gerrit-log mailing list