This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9356 ) Change subject: client: do not start connections in loopback mode ...................................................................... client: do not start connections in loopback mode Starting connections in loopback bode may cause confusion at the receiving end when the connection is switched from looback into an actual send-receive connection. The reason for this is by this the SSRC of the RTP stream will suddenly change. For the majority of usecases it is not necessary to loopback the incomming packets back to the receiver in the beginning. So lets use receive-only as a safe default. - use MGCP_CONN_RECV_ONLY instead of MGCP_CONN_RECV_LOOPBACK Change-Id: I44178434ee497bc1d5e9d5f6d92c13c1a09ae241 Related: OS#3104 --- M src/libosmo-mgcp-client/mgcp_client_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/src/libosmo-mgcp-client/mgcp_client_fsm.c b/src/libosmo-mgcp-client/mgcp_client_fsm.c index 6e1e7b8..07a65e6 100644 --- a/src/libosmo-mgcp-client/mgcp_client_fsm.c +++ b/src/libosmo-mgcp-client/mgcp_client_fsm.c @@ -112,7 +112,7 @@ .verb = MGCP_VERB_CRCX, .presence = (MGCP_MSG_PRESENCE_ENDPOINT | MGCP_MSG_PRESENCE_CALL_ID | MGCP_MSG_PRESENCE_CONN_MODE), .call_id = mgcp_ctx->conn_peer_local.call_id, - .conn_mode = MGCP_CONN_LOOPBACK, + .conn_mode = MGCP_CONN_RECV_ONLY, }; osmo_strlcpy(mgcp_msg.endpoint, mgcp_ctx->conn_peer_local.endpoint, MGCP_ENDPOINT_MAXLEN); -- To view, visit https://gerrit.osmocom.org/9356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I44178434ee497bc1d5e9d5f6d92c13c1a09ae241 Gerrit-Change-Number: 9356 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180529/4e8b71b1/attachment.htm>