Change in libosmocore[master]: ctrl: Introduce libosmoctrl.map to avoid unintended exports

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun May 27 10:46:25 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9331 )

Change subject: ctrl: Introduce libosmoctrl.map to avoid unintended exports
......................................................................

ctrl: Introduce libosmoctrl.map to avoid unintended exports

There are some symbols for use between control_cmd.c and control_if.c,
which are not supposed to be exported publicly.  Let's make sure we
keep those symbols local.

Change-Id: Ia85f36a9c4b2ebf4003718e0a230959638370320
---
M configure.ac
M src/ctrl/Makefile.am
A src/ctrl/libosmoctrl.map
3 files changed, 38 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/configure.ac b/configure.ac
index 6b9c66f..79ef9d4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -47,11 +47,13 @@
 	LTLDFLAGS_OSMOGB='-Wl,--version-script=$(srcdir)/libosmogb.map'
 	LTLDFLAGS_OSMOGSM='-Wl,--version-script=$(srcdir)/libosmogsm.map'
 	LTLDFLAGS_OSMOCODING='-Wl,--version-script=$(srcdir)/libosmocoding.map'
+	LTLDFLAGS_OSMOCTRL='-Wl,--version-script=$(srcdir)/libosmoctrl.map'
 	;;
 esac
 AC_SUBST(LTLDFLAGS_OSMOGB)
 AC_SUBST(LTLDFLAGS_OSMOGSM)
 AC_SUBST(LTLDFLAGS_OSMOCODING)
+AC_SUBST(LTLDFLAGS_OSMOCTRL)
 
 dnl checks for header files
 AC_HEADER_STDC
diff --git a/src/ctrl/Makefile.am b/src/ctrl/Makefile.am
index 71cc9a3..a51ae05 100644
--- a/src/ctrl/Makefile.am
+++ b/src/ctrl/Makefile.am
@@ -20,4 +20,6 @@
 libosmoctrl_la_SOURCES += control_vty.c
 endif
 
+EXTRA_DIST = libosmoctrl.map
+
 endif
diff --git a/src/ctrl/libosmoctrl.map b/src/ctrl/libosmoctrl.map
new file mode 100644
index 0000000..5b888a2
--- /dev/null
+++ b/src/ctrl/libosmoctrl.map
@@ -0,0 +1,34 @@
+LIBOSMOCTRL_1.0 {
+global:
+
+ctrl_cmd_cpy;
+ctrl_cmd_create;
+ctrl_cmd_def_is_zombie;
+ctrl_cmd_def_make;
+ctrl_cmd_def_send;
+#ctrl_cmd_exec;
+ctrl_cmd_exec_from_string;
+ctrl_cmd_handle;
+ctrl_cmd_install;
+ctrl_cmd_make;
+ctrl_cmd_parse;
+ctrl_cmd_parse2;
+ctrl_cmd_send;
+ctrl_cmd_send_to_all;
+ctrl_cmd_send_trap;
+ctrl_cmd_trap;
+ctrl_handle_alloc; /* could be removed? */
+ctrl_handle_alloc2; /* could be removed? */
+ctrl_handle_msg; /* only used in unit test */
+ctrl_interface_setup;
+ctrl_interface_setup_dynip;
+ctrl_interface_setup_dynip2;
+ctrl_lookup_register;
+ctrl_parse_get_num;
+ctrl_type_vals;
+ctrl_vty_get_bind_addr;
+ctrl_vty_init;
+osmo_ctrl_conn_alloc;
+
+local: *;
+};

-- 
To view, visit https://gerrit.osmocom.org/9331
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia85f36a9c4b2ebf4003718e0a230959638370320
Gerrit-Change-Number: 9331
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180527/0dd36e28/attachment.htm>


More information about the gerrit-log mailing list