This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9289 ) Change subject: store subscriber identity on paging ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/9289/1/src/libbsc/paging.c File src/libbsc/paging.c: https://gerrit.osmocom.org/#/c/9289/1/src/libbsc/paging.c@391 PS1, Line 391: conn->bsub = bsc_subscr_get(bsub); > this looks a bit odd as we're only incrementing the bsup use count in this patch, but we don't add a […] yes, I thought the same when reviewing my slightly old patch. The put is actually in gscon_cleanup(), i.e. the conn will keep its conn->bsub if one is there. So far there wasn't one. Oh wait, this patch should make sure there wasn't one before. There wouldn't be one, but if there ever was, we would leak reference counts. -- To view, visit https://gerrit.osmocom.org/9289 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ab7bedfe693bb4e42a04fb0585b94a730ff2d9b Gerrit-Change-Number: 9289 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Fri, 25 May 2018 11:29:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180525/7646534b/attachment.htm>