Change in osmo-sip-connector[master]: Implement MNCC Cause <-> SIP Call Error mapping

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu May 24 10:39:24 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9271 )

Change subject: Implement MNCC Cause <-> SIP Call Error mapping
......................................................................


Patch Set 1: Code-Review-1

(7 comments)

https://gerrit.osmocom.org/#/c/9271/1/src/mncc.c
File src/mncc.c:

https://gerrit.osmocom.org/#/c/9271/1/src/mncc.c@122
PS1, Line 122: 	
ws, please fix.


https://gerrit.osmocom.org/#/c/9271/1/src/sip.c
File src/sip.c:

https://gerrit.osmocom.org/#/c/9271/1/src/sip.c@54
PS1, Line 54: 	LOGP(DSIP, LOGL_NOTICE, "leg(%p) is now ringing.\n", leg);
Great, but unrelated to this change...
Please do it in a separate one.


https://gerrit.osmocom.org/#/c/9271/1/src/sip.c@182
PS1, Line 182: other->cause=1;
Do we have any enum or a group of defines for this?


https://gerrit.osmocom.org/#/c/9271/1/src/sip.c@235
PS1, Line 235: static void copy_cause_phrase(int *to_cause, char **to_phrase, 
ws ws


https://gerrit.osmocom.org/#/c/9271/1/src/sip.c@240
PS1, Line 240: } 
ws


https://gerrit.osmocom.org/#/c/9271/1/src/sip.c@248
PS1, Line 248: 	int sip_cause;	
ws


https://gerrit.osmocom.org/#/c/9271/1/src/sip.c@280
PS1, Line 280: 	
ws



-- 
To view, visit https://gerrit.osmocom.org/9271
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f9796c8ecdfdd68274e9b32e748d32a4b8dc273
Gerrit-Change-Number: 9271
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 24 May 2018 10:39:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180524/f70d03e2/attachment.htm>


More information about the gerrit-log mailing list