This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9262 ) Change subject: ipaccess: ipaccess_rcvmsg: Drop unneeded memcpy ...................................................................... ipaccess: ipaccess_rcvmsg: Drop unneeded memcpy Those values are not used anymore, since the old bfd is unregistered and the values for the new one will be overwritten by osmo_fd_register. Change-Id: I7ac74843cbed920a2fdc6ade7aef4d4de905939a --- M src/input/ipaccess.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 9a80d8e..5fd9ec3 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -194,7 +194,6 @@ newbfd = &ts->driver.ipaccess.fd; /* get rid of our old temporary bfd */ - memcpy(&newbfd->list, &bfd->list, sizeof(newbfd->list)); newbfd->fd = bfd->fd; newbfd->when |= bfd->when; /* preserve 'newbfd->when' flags potentially set by sign_link_up() */ newbfd->cb = bfd->cb; -- To view, visit https://gerrit.osmocom.org/9262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7ac74843cbed920a2fdc6ade7aef4d4de905939a Gerrit-Change-Number: 9262 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180523/be681a4b/attachment.htm>