This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9263 ) Change subject: ipaccess: Avoid using released line and bfd in ipaccess_fd_cb ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/9263/1/src/input/ipaccess.c File src/input/ipaccess.c: https://gerrit.osmocom.org/#/c/9263/1/src/input/ipaccess.c@183 PS1, Line 183: goto err; I don't really understand the semantics of the old code, and why we have it like that. Hoewever, the original behavior appears to have been to simply print an error message but continue normal processing (return 0) while you're propagating this up to the caller. This change also doesn't really seem to relate to the commit message? https://gerrit.osmocom.org/#/c/9263/1/src/input/ipaccess.c@392 PS1, Line 392: if (rc!=-EBADF && (what & BSC_FD_WRITE)) coding style (spaces). -- To view, visit https://gerrit.osmocom.org/9263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52faa9e6717137a7dab9c4e006eaa50b7367fc3e Gerrit-Change-Number: 9263 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Comment-Date: Wed, 23 May 2018 15:44:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180523/22399312/attachment.htm>