Change in libosmo-abis[master]: ipaccess: ipaccess_rcvmsg: Drop unneeded memcpy

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed May 23 15:00:12 UTC 2018


Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9262


Change subject: ipaccess: ipaccess_rcvmsg: Drop unneeded memcpy
......................................................................

ipaccess: ipaccess_rcvmsg: Drop unneeded memcpy

Those values are not used anymore, since the old bfd is unregistered and
the values for the new one will be overwritten by osmo_fd_register.

Change-Id: I7ac74843cbed920a2fdc6ade7aef4d4de905939a
---
M src/input/ipaccess.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/62/9262/1

diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index 9a80d8e..bbdc5af 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -194,7 +194,7 @@
 			newbfd = &ts->driver.ipaccess.fd;
 
 			/* get rid of our old temporary bfd */
-			memcpy(&newbfd->list, &bfd->list, sizeof(newbfd->list));
+			INIT_LLIST_HEAD(&newbfd->list);
 			newbfd->fd = bfd->fd;
 			newbfd->when |= bfd->when; /* preserve 'newbfd->when' flags potentially set by sign_link_up() */
 			newbfd->cb = bfd->cb;

-- 
To view, visit https://gerrit.osmocom.org/9262
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ac74843cbed920a2fdc6ade7aef4d4de905939a
Gerrit-Change-Number: 9262
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180523/3ab876ac/attachment.htm>


More information about the gerrit-log mailing list