Change in osmo-ttcn3-hacks[master]: L3_Templates: add template tr_GMM_DET_REQ_MT/ts_GMM_DET_ACCEPT_MT

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed May 23 07:17:31 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9247 )

Change subject: L3_Templates: add template tr_GMM_DET_REQ_MT/ts_GMM_DET_ACCEPT_MT
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/9247/1/library/L3_Templates.ttcn
File library/L3_Templates.ttcn:

https://gerrit.osmocom.org/#/c/9247/1/library/L3_Templates.ttcn@1886
PS1, Line 1886: 		template OCT1 cause := omit) := {
I would set cause := * for a receive template. This way a noin-specific invocation matches any detach request. Of also set dtt to ?, for the same reason. Using the template without any arguments shoiukd be the widest possible match, not one specific case.



-- 
To view, visit https://gerrit.osmocom.org/9247
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifea650994408c4dd83f46f6256565d38968bf843
Gerrit-Change-Number: 9247
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 23 May 2018 07:17:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180523/8234cfb3/attachment.htm>


More information about the gerrit-log mailing list