Change in osmo-bsc[master]: nat: Add jitter buffer on the uplink receiver

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun May 20 06:56:11 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9214 )

Change subject: nat: Add jitter buffer on the uplink receiver
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/9214/1/include/osmocom/bsc/bsc_nat.h
File include/osmocom/bsc/bsc_nat.h:

https://gerrit.osmocom.org/#/c/9214/1/include/osmocom/bsc/bsc_nat.h@180
PS1, Line 180: 	bool bts_use_jibuf;
I would prefer something like a sub-structure 

struct {
   ....
} bts_jitter;

This way it's very clear whihc members of the master struct are related to the jitter buffer [only] and which not.



-- 
To view, visit https://gerrit.osmocom.org/9214
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07b8a577caf731d59d68e3b3510ae2f9fd3dc93
Gerrit-Change-Number: 9214
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sun, 20 May 2018 06:56:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180520/7c06fcbc/attachment.htm>


More information about the gerrit-log mailing list