Change in libosmocore[master]: core/timer_compat: define CLOCK_BOOTTIME

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Sat May 19 12:12:44 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/7906 )

Change subject: core/timer_compat: define CLOCK_BOOTTIME
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/7906/1/include/osmocom/core/timer_compat.h
File include/osmocom/core/timer_compat.h:

https://gerrit.osmocom.org/#/c/7906/1/include/osmocom/core/timer_compat.h@119
PS1, Line 119: #define CLOCK_BOOTTIME 7
> so what does the magic 7 do in pre-2.6. […]
We are actually not using CLOCK_BOOTTIME anywhere in our code afaik, we only provide the possibility to use it together with other clocks in the API.

If CLOCK_BOOTTIME is not suported I would still efine it, then I would probably return EINVAL, as explained in man clock_gettime:
"EINVAL The clk_id specified is not supported on this system."

If we just pass that to clock_gettime, it's going to return EINVAL anyway most probably.



-- 
To view, visit https://gerrit.osmocom.org/7906
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d3a829700272ec8e5cf67379d8d85368230726
Gerrit-Change-Number: 7906
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Sat, 19 May 2018 12:12:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180519/ad432127/attachment.htm>


More information about the gerrit-log mailing list