This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.orgStefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/9211 ) Change subject: implement periodic Location Update expiry in the VLR ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/#/c/9211/2/src/libvlr/vlr.c File src/libvlr/vlr.c: https://gerrit.osmocom.org/#/c/9211/2/src/libvlr/vlr.c@469 PS2, Line 469: /* Table 10.5.33: The T3212 timeout value is coded as the > (why not use the entire line width. […] This comment was moved here, I didn't write it. You don't seem to like it. Should I just delete it? https://gerrit.osmocom.org/#/c/9211/2/src/libvlr/vlr.c@481 PS2, Line 481: vsub->expire_lu = GSM_SUBSCRIBER_NO_EXPIRATION; > hmm. […] I am not sure. This error really should not happen. I suppose leaving subscribers in memory is better than kicking off all subscribers in case of a problem with reading the clock. https://gerrit.osmocom.org/#/c/9211/2/src/libvlr/vlr.c@503 PS2, Line 503: LOGP(DVLR, LOGL_DEBUG, "IMSI=%s id=%llu: Location Update expired\n", vsub->imsi, vsub->id); > use vlr_subscr_name(). […] Sure. https://gerrit.osmocom.org/#/c/9211/2/src/libvlr/vlr.c@1192 PS2, Line 1192: osmo_timer_setup(&vlr->lu_expire_timer, vlr_subscr_expire_lu, vlr); > (for me it would make sense to keep osmo_timer_setup() right next to osmo_timer_schedule() below) It's not in the same function. Looks like gerrit has fooled you by leaving out some lines in-between... -- To view, visit https://gerrit.osmocom.org/9211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebdee8b12d22acfcfb265ee41e71cfc8d9eb3ba9 Gerrit-Change-Number: 9211 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Comment-Date: Fri, 18 May 2018 10:08:39 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180518/3d7f504e/attachment.htm>