Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu May 17 20:13:16 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9218 )

Change subject: add counter for connection attempts from BTS with unknown unit id
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/9218/1/src/libbsc/bts_ipaccess_nanobts.c
File src/libbsc/bts_ipaccess_nanobts.c:

https://gerrit.osmocom.org/#/c/9218/1/src/libbsc/bts_ipaccess_nanobts.c@471
PS1, Line 471: 		rate_ctr_inc(&bsc_gsmnet->bsc_ctrs->ctr[BSC_CTR_BTS_UNKNOWN_UNIT_ID]);
this code is inserted *before* you know it's an OML or a RSL connection. The dispatch between OML/RSL is further down below in the switch statement.  So technically, you don't know it's an OML connection.  I guess the best way is to rename the counter and description (and possibly commit log message) to simply say "Connections with unknown IPA CCM Unit ID" without referring to OML or RSL explicitly.



-- 
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 17 May 2018 20:13:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180517/f0b1e22c/attachment.htm>


More information about the gerrit-log mailing list