Change in osmo-bsc[master]: show all global counters of osmo-bsc in vty

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu May 17 20:11:06 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9217 )

Change subject: show all global counters of osmo-bsc in vty
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/9217/1/src/libbsc/bsc_vty.c
File src/libbsc/bsc_vty.c:

https://gerrit.osmocom.org/#/c/9217/1/src/libbsc/bsc_vty.c@4143
PS1, Line 4143: void openbsc_vty_print_statistics(struct vty *vty, struct gsm_network *net)
We can merge this patch first, but I think it would be actually nice to have this as part of libosmocore.  It should be the same for all applications, as it's truly generic.  libosmovty depends on libosmocore, and rate_ctr are in libosmcoore, i.e. anyone using libosmovty should automatically get the "print statistics" installed.  Maybe we should call it "print rate-counters" instead, as this will not clash with any existing VTY commands code like this installs inside the applications, so we can handle this in a graceful way (old programs with new libosmocore, ...)



-- 
To view, visit https://gerrit.osmocom.org/9217
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58ae04e1960774d760e3ebb54a4f307c9f753655
Gerrit-Change-Number: 9217
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 17 May 2018 20:11:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180517/35d60389/attachment.htm>


More information about the gerrit-log mailing list