This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9220 ) Change subject: remove redundant unconditional PKG_CHECK_MODULES for libsmpp ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/9220/2/tests/smpp/Makefile.am File tests/smpp/Makefile.am: https://gerrit.osmocom.org/#/c/9220/2/tests/smpp/Makefile.am@1 PS2, Line 1: if BUILD_SMPP > It's probably cleaner to move this if to tests/Makefile.am when we add it to SUBDIR. we also put Makefile paths in configure.ac and can't do that conditionally, so not 100% sure that we should make the entire subdir conditional? -- To view, visit https://gerrit.osmocom.org/9220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4a8a5c970c04a6257ee4c8e3977e98c4ddfda13 Gerrit-Change-Number: 9220 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 17 May 2018 15:34:24 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180517/c85c3a0b/attachment.htm>