Change in libosmo-netif[master]: osmux: change log lvl of batch full to debug

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu May 17 11:21:57 UTC 2018


Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/9173 )

Change subject: osmux: change log lvl of batch full to debug
......................................................................

osmux: change log lvl of batch full to debug

This message is expected as all code filling batches call
osmux_batch_enqueue() and checks for error to know if it must tell the
user of the lib to call osmux_xfrm_input_deliver.

Change-Id: I3d8227f2281f6ca92fd2502d3e328765dc7ecfe9
---
M src/osmux.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmux.c b/src/osmux.c
index 46170ba..7a6ce60 100644
--- a/src/osmux.c
+++ b/src/osmux.c
@@ -356,7 +356,7 @@
 static int osmux_batch_enqueue(struct msgb *msg, struct osmux_circuit *circuit,
 				uint8_t batch_factor)
 {
-	/* Too many messages per batch, discard it. The counter field of the
+	/* Validate amount of messages per batch. The counter field of the
 	 * osmux header is just 3 bits long, so make sure it doesn't overflow.
 	 */
 	if (circuit->nmsgs >= batch_factor || circuit->nmsgs >= 8) {
@@ -366,7 +366,7 @@
 		if (rtph == NULL)
 			return -1;
 
-		LOGP(DLMUX, LOGL_ERROR, "too many messages for this RTP "
+		LOGP(DLMUX, LOGL_DEBUG, "Batch is full for RTP "
 					"ssrc=%u\n", rtph->ssrc);
 		return -1;
 	}

-- 
To view, visit https://gerrit.osmocom.org/9173
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d8227f2281f6ca92fd2502d3e328765dc7ecfe9
Gerrit-Change-Number: 9173
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180517/cd50c3af/attachment.htm>


More information about the gerrit-log mailing list