Change in osmo-msc[master]: implement periodic Location Update expiry in the VLR

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/9211 )

Change subject: implement periodic Location Update expiry in the VLR
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/#/c/9211/1/src/libmsc/subscr_conn.c
File src/libmsc/subscr_conn.c:

https://gerrit.osmocom.org/#/c/9211/1/src/libmsc/subscr_conn.c@207
PS1, Line 207: 	/* Stop location update expiry for this subscriber. */
> the comment states what's easily deducted from the line below. […]
Next patch contains has a better comment.

We want to prevent LU expiry from interfering with subscribers with active connections.


https://gerrit.osmocom.org/#/c/9211/1/src/libvlr/vlr.c
File src/libvlr/vlr.c:

https://gerrit.osmocom.org/#/c/9211/1/src/libvlr/vlr.c@465
PS1, Line 465: vlr_subscr_enable_expire_lu(struct vlr_subscr *vsub)
> we don't generally break lines ahead of the function name
Indeed. Fixed in next patch set.


https://gerrit.osmocom.org/#/c/9211/1/src/libvlr/vlr.c@475
PS1, Line 475: 	if (osmo_gettimeofday(&now, NULL) == 0) {
> I think we had the discussion about gettimeofday already (think of time adjustments due to ntpdate,  […]
I was using gettimeofday only because the msc_vlr tests didn't support fake time with clock_gettime() yet.

Fixed in next patch set.
Adding support for this to the test suite was pretty straightforward.


https://gerrit.osmocom.org/#/c/9211/1/src/libvlr/vlr.c@481
PS1, Line 481: 		vsub->expire_lu = GSM_SUBSCRIBER_NO_EXPIRATION; /* XXX */
> what does the XXX mean here?
This subscriber will have LU expiry disabled.

Better comment in next patch set.



-- 
To view, visit https://gerrit.osmocom.org/9211
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebdee8b12d22acfcfb265ee41e71cfc8d9eb3ba9
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Comment-Date: Thu, 17 May 2018 11:01:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180517/b48e8561/attachment.htm>