Change in osmo-msc[master]: implement periodic Location Update expiry in the VLR

[Harald Welte]

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9211 )

Change subject: implement periodic Location Update expiry in the VLR
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/#/c/9211/1/src/libmsc/subscr_conn.c
File src/libmsc/subscr_conn.c:

https://gerrit.osmocom.org/#/c/9211/1/src/libmsc/subscr_conn.c@207
PS1, Line 207: 	/* Stop location update expiry for this subscriber. */
the comment states what's easily deducted from the line below.  What the comment doesn't say (and I don't understand): Why are we stopping expiration here?


https://gerrit.osmocom.org/#/c/9211/1/src/libvlr/vlr.c
File src/libvlr/vlr.c:

https://gerrit.osmocom.org/#/c/9211/1/src/libvlr/vlr.c@465
PS1, Line 465: vlr_subscr_enable_expire_lu(struct vlr_subscr *vsub)
we don't generally break lines ahead of the function name


https://gerrit.osmocom.org/#/c/9211/1/src/libvlr/vlr.c@475
PS1, Line 475: 	if (osmo_gettimeofday(&now, NULL) == 0) {
I think we had the discussion about gettimeofday already (think of time adjustments due to ntpdate, ...), especially on embedded systems without RTC, where at boot time we don't have a valid wall-clock time.


https://gerrit.osmocom.org/#/c/9211/1/src/libvlr/vlr.c@481
PS1, Line 481: 		vsub->expire_lu = GSM_SUBSCRIBER_NO_EXPIRATION; /* XXX */
what does the XXX mean here?



-- 
To view, visit https://gerrit.osmocom.org/9211
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebdee8b12d22acfcfb265ee41e71cfc8d9eb3ba9
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 17 May 2018 09:46:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180517/36a09c21/attachment.htm>