Change in osmo-pcu[master]: Fix "left shift of 1 by 31 places cannot be represented in type 'int'...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue May 15 14:20:21 UTC 2018


Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9168


Change subject: Fix "left shift of 1 by 31 places cannot be represented in type 'int'" errors
......................................................................

Fix "left shift of 1 by 31 places cannot be represented in type 'int'" errors

Change-Id: I88e92be37caab399fc1d55f07699d601f6ea96c0
---
M src/mslot_class.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/68/9168/1

diff --git a/src/mslot_class.c b/src/mslot_class.c
index 2a482f1..6b311ea 100644
--- a/src/mslot_class.c
+++ b/src/mslot_class.c
@@ -239,7 +239,7 @@
 		return -1;
 
 	for (tfi = 0; tfi < 32; tfi++) {
-		if (!(tfi_map & (1 << tfi)))
+		if (!(tfi_map & (1u << tfi)))
 			return tfi;
 	}
 
@@ -268,8 +268,8 @@
 
 bool mslot_test_and_set_bit(uint32_t *bits, size_t elem)
 {
-	bool was_set = bits[elem/32] & (1 << (elem % 32));
-	bits[elem/32] |= (1 << (elem % 32));
+	bool was_set = bits[elem/32] & (1u << (elem % 32));
+	bits[elem/32] |= (1u << (elem % 32));
 
 	return was_set;
 }

-- 
To view, visit https://gerrit.osmocom.org/9168
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88e92be37caab399fc1d55f07699d601f6ea96c0
Gerrit-Change-Number: 9168
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180515/129be6f7/attachment.htm>


More information about the gerrit-log mailing list