[PATCH] osmo-bts[master]: scheduler_trx: Add reminders to use libosmocore functions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu May 10 10:11:57 UTC 2018


Review at  https://gerrit.osmocom.org/8103

scheduler_trx: Add reminders to use libosmocore functions

Let' wait until the just-merged osmo_timerfd_* functions
of Change-Id Ibeffba7c997252c003723bcd5d14122c4ded2fe7 have made it
into the next tagged release, and then replace the implementation
here.

Change-Id: Ic0f0a7437b6acb535177e5ad6ac7a6d336654c66
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/03/8103/1

diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index 4c4ae6c..2b91d66 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -1427,6 +1427,7 @@
 }
 
 /*! disable the osmocom-wrapped timerfd */
+/* FIXME: Use libosmocore after release with Ibeffba7c997252c003723bcd5d14122c4ded2fe7 was made */t
 static int timer_ofd_disable(struct osmo_fd *ofd)
 {
 	const struct itimerspec its_null = {
@@ -1441,6 +1442,7 @@
  *  \param[in] first Relative time at which the timer should first execute (NULL = \a interval)
  *  \param[in] interval Time interval at which subsequent timer shall fire
  *  \returns 0 on success; negative on error */
+/* FIXME: Use libosmocore after release with Ibeffba7c997252c003723bcd5d14122c4ded2fe7 was made */
 static int timer_ofd_schedule(struct osmo_fd *ofd, const struct timespec *first,
 			      const struct timespec *interval)
 {
@@ -1469,6 +1471,7 @@
  *  We simply initialize the data structures here, but do not yet
  *  schedule the timer.
  */
+/* FIXME: Use libosmocore after release with Ibeffba7c997252c003723bcd5d14122c4ded2fe7 was made */
 static int timer_ofd_setup(struct osmo_fd *ofd, int (*cb)(struct osmo_fd *, unsigned int), void *data)
 {
 	ofd->cb = cb;

-- 
To view, visit https://gerrit.osmocom.org/8103
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0f0a7437b6acb535177e5ad6ac7a6d336654c66
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list