osmo-gsm-tester[master]: tests: voice: Move logic to testlib.py

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon May 7 21:18:41 UTC 2018


Patch Set 1: Code-Review-1

erm, what? you want to manipulate the python path from a test script? You introduce a "lib" to contain common parts to be re-used in several tests, I think to prepare incorporating config in the test scripts in the upcoming patches, config which should be in a suite.conf instead.

If we introduce common code snippets to be re-used across test scripts, let's just put them in the normal place where all the other files are, i.e. in src/osmo_gsm_tester/, and let's not manipulate the python path from test scripts. Next, the snippets should be modular, i.e. not establish a network and do a phone call in one, at least split off the phone call so that you could e.g. do two phone calls one after the other.

(but I still think in this particular instance we don't need to repeat the voice call code just yet, if we configure pchans by scenarios)

-- 
To view, visit https://gerrit.osmocom.org/8062
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5cfcc56970380a7c5400186fac5f504263d63c5f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list