osmo-gsm-tester[master]: tests: voice: Add tests to verify dynamic timeslots during p...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon May 7 21:03:22 UTC 2018


Patch Set 2: Code-Review-2

(1 comment)

as much as I'd like the dyn TS tested automatically soon, I'm afraid this goes in the wrong direction...

https://gerrit.osmocom.org/#/c/8063/2/suites/voice/mo_mt_call_dyn_ipa.py
File suites/voice/mo_mt_call_dyn_ipa.py:

Line 16:     bts.set_trx_phy_channel(0, 7, 'PDCH')
I actually would have expected this to be part of a scenarios/dyn-ts-foo.conf the same way we configure specific ciphers. Various BTS models will support or not support specific pchan types, e.g. osmo-bts-sysmo supports all, while ericsson RBS would support only TCH/F_TCH/H_PDCH, and ip.access would support only TCH/F_PDCH. I would then have expected to invoke the utterly unchanged 'voice' suite, just with a different scenario selection to have different pchan configured. So that instead of copying each and every voice call test and each and every GPRS test for each particular pchan selection, we just run the utterly unchanged suites for different scenario selections. I think it's fairly important to maintain the config parameters separately from the actual test scripts.


-- 
To view, visit https://gerrit.osmocom.org/8063
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5e61eaff39ac7a6585dc7de2aeb2469dd2ce726
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list