osmo-bts[master]: let osmo-bts log a special notice if OML connection is close...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon May 7 14:55:13 UTC 2018


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/8056/1/src/common/abis.c
File src/common/abis.c:

Line 153: 		if (g_bts->oml_conn_established_timestamp.tv_sec != 0 && osmo_gettimeofday(&now, NULL) == 0 &&
it's not super critical, I guess, but gettimeofday is not monotonic.  So if ntpdate or gpsdate or whatever else is adjusting the time/date meanwhile, we'll get quite some weird output / behavior.  "clock_gettime(CLOCK_MONOTONIC, &tp);" would prevent that.


-- 
To view, visit https://gerrit.osmocom.org/8056
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I476ac797458b5a46edea3ae9cfbd491fd7f77f47
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list