[PATCH] meta-telephony[201705]: recipes-osmocom: Remove manual recreation of tarball-version...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Sun May 6 21:02:11 UTC 2018


Review at  https://gerrit.osmocom.org/8047

recipes-osmocom: Remove manual recreation of tarball-version file

The reasoning behind this manual operation in configure_prepend doesn't
apply anymore. In pyro it seems configure can properly set the version,
and it was seen during latest releases in upstream that having those
manually is counterproductive, because then outdated versions are used.

Change-Id: I0c1ad67224cde2f3a25c6fe945509586ec84de0c
---
M recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
M recipes-osmocom/openbsc/openbsc.inc
2 files changed, 0 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/47/8047/1

diff --git a/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb b/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
index 23ee6b7..b353acb 100644
--- a/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
+++ b/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
@@ -14,11 +14,6 @@
 SYSTEMD_PACKAGES = "osmo-stp"
 SYSTEMD_SERVICE_osmo-stp = "osmo-stp.service"
 
-# because "${WORKDIR}/git" is not a git repo, it can't figure out the version
-do_configure_prepend() {
-    echo "${PV}" > ${S}/.tarball-version
-}
-
 do_install_append() {
 	install -d ${D}${systemd_system_unitdir}/
 	install -d ${D}${sysconfdir}/osmocom/
diff --git a/recipes-osmocom/openbsc/openbsc.inc b/recipes-osmocom/openbsc/openbsc.inc
index ba0d75c..5e4b10d 100644
--- a/recipes-osmocom/openbsc/openbsc.inc
+++ b/recipes-osmocom/openbsc/openbsc.inc
@@ -18,11 +18,6 @@
 
 inherit autotools update-rc.d pkgconfig
 
-# because "${WORKDIR}/git" is not a git repo, it can't figure out the version
-do_configure_prepend() {
-	echo "${PV}" > ${S}/.tarball-version
-}
-
 do_install_append() {
 	install -d ${D}${sysconfdir}/osmocom
 	install -m 0660 ${S}/doc/examples/osmo-nitb/nanobts/openbsc.cfg ${D}${sysconfdir}/osmocom/osmo-nitb.cfg

-- 
To view, visit https://gerrit.osmocom.org/8047
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c1ad67224cde2f3a25c6fe945509586ec84de0c
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>



More information about the gerrit-log mailing list