osmo-hlr[master]: move creation of insert subscriber data messages to a common...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu May 3 17:26:43 UTC 2018


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/7992/1/src/gsup_server.c
File src/gsup_server.c:

Line 372: 	msisdn_enc = talloc_size(gsup, OSMO_GSUP_MAX_CALLED_PARTY_BCD_LEN);
simply OSMO_ASSERT on the talloc result, in all calls (both the one for gsup above, as well as the others here...


https://gerrit.osmocom.org/#/c/7992/1/src/luop.c
File src/luop.c:

Line 53: 	if (msg_out == NULL) {
same here. OSMO_ASSERT(msg_out) is sufficient.


-- 
To view, visit https://gerrit.osmocom.org/7992
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a92ca34cdaadca9eacc774bb1ca386c325ba865
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list