osmo-hlr[master]: rewrite subscriber_update_notify() without calls into luop

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed May 2 10:15:54 UTC 2018


Patch Set 6: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/7743/6/src/hlr.c
File src/hlr.c:

Line 260: 		/* The client didn't send a CN_DOMAIN IE; assume circuit-switched */
I really wanted to +2 now, but damn:

Looking in our GSUP specs, e.g. osmohlr-usermanual ( http://ftp.osmocom.org/docs/latest/ ) the CN Domain is indeed optional (11.5.6 Update Location Request)

but 11.6.15 CN Domain says:

For backwards compatibility reasons, if no CN Domain IE is present within a request, the PS Domain is assumed.


-- 
To view, visit https://gerrit.osmocom.org/7743
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06c43ece2b48dc63d599000eb6d6d51e08963067
Gerrit-PatchSet: 6
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list