This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review+1
(2 comments)
none of the remarks really matter since it's just a fairly trivial static function...
https://gerrit.osmocom.org/#/c/7960/1/src/gsm/lapdm.c
File src/gsm/lapdm.c:
Line 540: /* determine if receiving a given LAPDm message is not permitted */
(cosmetically, would prefer dropping the "_not"; also explaining the return value)
Line 545: if (lctx->format == LAPD_FORM_U && lctx->s_u == LAPD_U_SABM) {
> May we unpack this condition in the following way:
or even
if (!(lctx->format == LAPD_FORM_U && lctx->s_u == LAPD_U_SABM))
return 0;
above
--
To view, visit https://gerrit.osmocom.org/7960
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c2c103cdc7f9a45d7b2080c572f559fc3db58e4
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: Yes