This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgPatch Set 2: > > As I saig, we probably want to cast to (uint8_t*) > > Right, probably... except not, because I already tried uint8_t > before I pushed the first patch set, and the compiler warned: > > eeprom.c:663:57: warning: cast from pointer to integer of different > size [-Wpointer-to-int-cast] > err = eeprom_read( EEPROM_CFG_START_ADDR + ((uint8_t)&ee.cfg.v1.rfClk > - (uint8_t)&ee), sizeof(ee.cfg.v1.rfClk), (char *)&ee.cfg.v1.rfClk > ); > > In fact, the only type that doesn't warn for me if the state of the > code before the patch that broke this, that is to say. uint32_t. So > it's compiler of system dependent. Try exactly '(uint8_t *)', because there is an important difference. The '(uint8_t *)' means casting to pointer (and we need exactly pointer arithmetics), while '(uint8_t)' (without asterisk) means casting a pointer address into a number. -- To view, visit https://gerrit.osmocom.org/7572 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa7318387ad7bb248c261b1f428019244039e7d2 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Keith Whyte <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-HasComments: No