osmo-bts[master]: osmo-bts-sysmo eeprom.c Restore ability to read/write EEPROM

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Mar 29 11:28:53 UTC 2018


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/7572/1/src/osmo-bts-sysmo/eeprom.c
File src/osmo-bts-sysmo/eeprom.c:

Line 498:             err = eeprom_read( EEPROM_CFG_START_ADDR + ((int)&ee.cfg.v1.sysInfo - (int)&ee), sizeof(ee.cfg.v1.sysInfo), (char *)&ee.cfg.v1.sysInfo );
I fail to see how this change can make it work, as afaik the sysmobts is a 32bit arch.

The only difference I can see is the signed/unsigned type in case addr of sysInfo is smaller than ee. Which means to me that we should probably don't care about the substraction here but about the result.
Can you verify this is the case? eg: printing %p both addresses.


-- 
To view, visit https://gerrit.osmocom.org/7572
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa7318387ad7bb248c261b1f428019244039e7d2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list