This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review+1 (1 comment) This is good for consistency, though I don't think it has any effect on run-time behaviour. Does it? https://gerrit.osmocom.org/#/c/7510/1/src/libbsc/paging.c File src/libbsc/paging.c: Line 345: return 0; > I think paging was always returning the number of dispatched pagings; could There are more inconsistencies here, e.g. page_subscriber() in osmo_bsc_bssap.c, which has "0 on success and negative on error" semantics, directly returns a value from bsc_grace_paging_request() which has "number of bts paged" semantics. Given that we deliberately don't check return values from page_subscriber(), we should probably just convert all the paging functions to return 'void'. -- To view, visit https://gerrit.osmocom.org/7510 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48f5efbcddd98e15256edfca06ba0ae6acb5bab1 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de> Gerrit-HasComments: Yes