[PATCH] osmo-ttcn3-hacks[master]: MNCC_Emulation: Make ExpectedCreateCallback work for SETUP_R...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Mar 26 21:12:49 UTC 2018


Review at  https://gerrit.osmocom.org/7519

MNCC_Emulation: Make ExpectedCreateCallback work for SETUP_REQ, too

In server mode, we need to handle SETUP_REQ in ExpectedCreateCallback,
not only SETUP_IND like in client mode.

Change-Id: I988668cac9970af12d59d05a3a9facca257851c6
---
M library/MNCC_Emulation.ttcn
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/7519/1

diff --git a/library/MNCC_Emulation.ttcn b/library/MNCC_Emulation.ttcn
index 0669266..59e3e77 100644
--- a/library/MNCC_Emulation.ttcn
+++ b/library/MNCC_Emulation.ttcn
@@ -390,8 +390,9 @@
 	var charstring dest_number;
 	var integer i;
 
-	if (not ischosen(conn_ind.u.signal) or conn_ind.msg_type != MNCC_SETUP_IND) {
-		setverdict(fail, "MNCC ExpectedCreateCallback needs MNCC_SETUP_IND");
+	if (not ischosen(conn_ind.u.signal) or
+	    (conn_ind.msg_type != MNCC_SETUP_IND and conn_ind.msg_type != MNCC_SETUP_REQ)) {
+		setverdict(fail, "MNCC ExpectedCreateCallback needs MNCC_SETUP_{IND,REQ}");
 		return ret;
 	}
 	dest_number := conn_ind.u.signal.called.number;

-- 
To view, visit https://gerrit.osmocom.org/7519
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I988668cac9970af12d59d05a3a9facca257851c6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list