osmo-bsc[master]: libbsc: nokia_site: Fix uninitialized return val

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Mar 26 16:58:19 UTC 2018


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/7508/1/src/libbsc/bts_nokia_site.c
File src/libbsc/bts_nokia_site.c:

Line 1237: 		ret = abis_nm_sendmsg(bts, msg);
change in behavior: previously, abis_nm_sendmsg() could return a positive value in the last loop iteration, which would then be returned below.

Taken a look, and it (ultimately abis_sendmsg()) never returns positive value so this is fine.


-- 
To view, visit https://gerrit.osmocom.org/7508
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic60c8c632a6ddadb8f197d56cc68c2dbfc121d05
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list