[PATCH] osmo-bsc[master]: bssap: Log non handled paging requests

[Pau Espin Pedrol]

Review at  https://gerrit.osmocom.org/7511

bssap: Log non handled paging requests

Return code in bssap_test is changed to ack it was sent and prevent the
log from being printed.

Change-Id: Ie8075d076cc34570fefce3beb577567707a29d4e
---
M src/osmo-bsc/osmo_bsc_bssap.c
M tests/bssap/bssap_test.c
2 files changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/11/7511/1

diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index 3cd6051..6eba359 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -260,6 +260,8 @@
 	    bts->nr, mi_string, tmsi, tmsi, lac);
 
 	ret = bsc_grace_paging_request(msc->network->bsc_data->rf_ctrl->policy, subscr, chan_needed, msc, bts);
+	if (!ret)
+		LOGP(DMSC, LOGL_ERROR, "Paging request not handled!\n");
 
 	/* the paging code has grabbed its own references */
 	bsc_subscr_put(subscr);
diff --git a/tests/bssap/bssap_test.c b/tests/bssap/bssap_test.c
index 5601e29..0cbf34a 100644
--- a/tests/bssap/bssap_test.c
+++ b/tests/bssap/bssap_test.c
@@ -50,7 +50,7 @@
 	else
 		fprintf(stderr, "BSC paging started with LAC %u\n", subscr->lac);
 	OSMO_ASSERT(gl_expect_lac == subscr->lac);
-	return 0;
+	return 1;
 }
 
 struct {

-- 
To view, visit https://gerrit.osmocom.org/7511
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8075d076cc34570fefce3beb577567707a29d4e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>